Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update os_login public ssh key to be loaded dynamically #17

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: update os_login public ssh key to be loaded dynamically #17

merged 1 commit into from
Oct 18, 2023

Conversation

sydrawat01
Copy link
Member

The OS Login resource now uses an environment variable ssh_key_file that loads the public ssh key to SSH into the GCP compute instance launched by the terraform template

Fixes issue #16

@sydrawat01
fix: update os_login public ssh key to be loaded dynamically
6627bd1 
The OS Login resource now uses an environment variable `ssh_key_file`
that loads the public ssh key to SSH into the GCP compute instance
launched by the terraform template

Fixes issue #16
@sydrawat01 sydrawat01 requested a review from rishabNeu October 18, 2023 20:15
@sydrawat01 sydrawat01 linked an issue Oct 18, 2023 that may be closed by this pull request
OS_login key to be provided via tfvars #16
Closed
rishabNeu
rishabNeu approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@rishabNeu rishabNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rishabNeu rishabNeu merged commit 60d7b09 into csye7125-fall2023-group05:master Oct 18, 2023
1 check passed
@rishabNeu rishabNeu deleted the oslogin branch October 18, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabNeu rishabNeu rishabNeu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OS_login key to be provided via tfvars
2 participants
@sydrawat01 @rishabNeu